Improve DISTINCT queries on PostgreSQL via recursive CTE#730
Open
bubiche wants to merge 1 commit intorails:mainfrom
Open
Improve DISTINCT queries on PostgreSQL via recursive CTE#730bubiche wants to merge 1 commit intorails:mainfrom
bubiche wants to merge 1 commit intorails:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to improve performance issues with PostgreSQL as stated here. Follow up of #397
PostgreSQL lacks MySQL's Loose Index Scan, so
DISTINCTqueries onqueue_namedegrade to full index scans on large tables. The recursive CTE walks the B-tree index jumping between distinct values.I have encapsulate the database specific logic in
Record::LooseDistinctso the rest can just usedistinct_values_of, which uses recursive CTE to emulate loose index scan on PostgreSQL and normalDISTINCTquery for MySQL/SQLite.This should help with:
QueueSelector). We have had situations wheresolid_queue_ready_executionsexploded even though it's normally small due to issues in other parts of the system and this would have helped.Queue.all), this should solve Slow DISTINCT query for finding queue names with Solid Queue mission_control-jobs#160